[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ezjail] [PATCH] "Locally configured IP" check in ezjail-admin is not 100% reliable



On 14.01.12 18:59, Thomas Steen Rasmussen wrote:

> The patch below changes ezjail-admin to parse the
> output of ifconfig instead of using ping to determine if an
> ip address is locally configured. This will also work even if a
> firewall is blocking pings to the IP address in question.

Hello,

thanks for the patch. I had something similar in place before, but I
hesitate parsing userland tools' output as it is not standardized and
may be subject to changes. I'd then have a hard time handling version
differences. Also ... see your other mail for examples of parsing
outputs to go wrong.

The ping utility on the other hand provides a nice binary (in a yes/no
sense) API that I thought would handle all the cases neatly without me
having to worry what it's output might look in 5 years.

While I appreciate your patch, I check if there's another stable way to
list all the IP addresses before I commit.

Thanks and regards,

  erdgeist